JuliaArrays / ArrayInterface.jl

Designs for new Base array interface primitives, used widely through scientific machine learning (SciML) and other organizations
https://docs.sciml.ai/ArrayInterface/stable/
MIT License
134 stars 37 forks source link

Index trait for resulting array's shape #314

Closed Tokazama closed 2 years ago

Tokazama commented 2 years ago

Part of the problem that #297 was working around was the absence of any information related to how an index type translates into the shape of the resulting array. Some of the problems discussed in #312 are also related to this. I'll be following this up with a couple internal changes in ArrayInterface, but I want to do this piecewise to ensure I don't break anything by changing it all at once.

codecov[bot] commented 2 years ago

Codecov Report

Merging #314 (15ce4ba) into master (d9b5089) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files           9        9           
  Lines        1399     1399           
=======================================
  Hits         1280     1280           
  Misses        119      119           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9b5089...15ce4ba. Read the comment docs.