search

JuliaArrays / ArrayInterface.jl

Designs for new Base array interface primitives, used widely through scientific machine learning (SciML) and other organizations
https://docs.sciml.ai/ArrayInterface/stable/
MIT License
134 stars 37 forks source link

ArrayInterfaceStaticArraysCore needs latest ArrayInterfaceCore #359

Closed chriselrod closed 2 years ago

chriselrod commented 2 years ago

As is, the package resolver is likely to match the latest static arrays core with old array interface cores, causing undefmatrix not defined errors. @oscardssmith

chriselrod commented 2 years ago

This is what I get from the latest version:

julia> using ArrayInterfaceCore

julia> using ArrayInterfaceStaticArraysCore
[ Info: Precompiling ArrayInterfaceStaticArraysCore [dd5226c6-a4d4-4bc7-8575-46859f9c95b9]
ERROR: LoadError: UndefVarError: undefmatrix not defined
Stacktrace:
 [1] getproperty(x::Module, f::Symbol)
   @ Base ./Base.jl:31
 [2] top-level scope
   @ ~/.julia/packages/ArrayInterfaceStaticArraysCore/DxGup/src/ArrayInterfaceStaticArraysCore.jl:6
 [3] include
   @ ./Base.jl:419 [inlined]
 [4] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
   @ Base ./loading.jl:1554
 [5] top-level scope
   @ stdin:1
in expression starting at /home/chriselrod/.julia/packages/ArrayInterfaceStaticArraysCore/DxGup/src/ArrayInterfaceStaticArraysCore.jl:1
in expression starting at stdin:1
ERROR: Failed to precompile ArrayInterfaceStaticArraysCore [dd5226c6-a4d4-4bc7-8575-46859f9c95b9] to /home/chriselrod/.julia/compiled/v1.8/ArrayInterfaceStaticArraysCore/jl_0NObzS.
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
   @ Base ./loading.jl:1707
 [3] compilecache
   @ ./loading.jl:1651 [inlined]
 [4] _require(pkg::Base.PkgId)
   @ Base ./loading.jl:1337
 [5] _require_prelocked(uuidkey::Base.PkgId)
   @ Base ./loading.jl:1200
 [6] macro expansion
   @ ./loading.jl:1180 [inlined]
 [7] macro expansion
   @ ./lock.jl:223 [inlined]
 [8] require(into::Module, mod::Symbol)
   @ Base ./loading.jl:1144
codecov[bot] commented 2 years ago

Codecov Report

Merging #359 (642e464) into master (0d529c4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files           9        9           
  Lines        1337     1337           
=======================================
  Hits         1207     1207           
  Misses        130      130

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

oscardssmith commented 2 years ago

we should yank the previous version since we don't want it to get chosen by the resolver

ChrisRackauckas commented 2 years ago

please do.

chriselrod commented 2 years ago

https://github.com/JuliaRegistries/General/pull/70213