search

JuliaArrays / ArrayInterface.jl

Designs for new Base array interface primitives, used widely through scientific machine learning (SciML) and other organizations
https://docs.sciml.ai/ArrayInterface/stable/
MIT License
134 stars 37 forks source link

Fix BigFloat QR instance and test better #406

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

Found in https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/4527032588/jobs/8065045759#step:6:517 that there's a special case to consider here. Now it's better tested.

codecov[bot] commented 1 year ago

Codecov Report

Merging #406 (a26b85a) into master (ba02e0c) will decrease coverage by 72.64%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #406       +/-   ##
==========================================
- Coverage   75.22%   2.58%   -72.64%     
==========================================
  Files           7       7               
  Lines         561     541       -20     
==========================================
- Hits          422      14      -408     
- Misses        139     527      +388
Impacted Files Coverage Δ
src/ArrayInterface.jl 4.36% <0.00%> (-70.04%) :arrow_down:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more