Various fixes to make the package work with v0.5

JuliaArrays / ArrayViews.jl

A Julia package to explore a new system of array views

MIT License

19 stars 18 forks source link

Various fixes to make the package work with v0.5 #47

Closed lindahua closed 7 years ago

lindahua commented 7 years ago

The PR aims to bring this package up to date, and in particular to make it work with v0.5.

To avoid the conflict with Base.view. This PR deprecates view and unsafe_view in favour of new names aview and unsafe_aview.

I just run the benchmark again. Base.view seems to be as fast as unsafe_aview for most cases. To be honest, the mission of this package has completed.

StefanKarpinski commented 7 years ago

Hi @lindahua! Long time no see :)

lindahua commented 7 years ago

If there is no objection, I will merge this in one day.