search

JuliaArrays / ArrayViews.jl

A Julia package to explore a new system of array views
MIT License
19 stars 18 forks source link

Fix deprecation loop #51

Closed goretkin closed 6 years ago

andreasnoack commented 6 years ago

Would you mind adjusting .travis.yml to enable testing 0.6 as part of this PR?

goretkin commented 6 years ago

Like that?

andreasnoack commented 6 years ago

Exactly. Now we'll know if things work on 0.6.

goretkin commented 6 years ago

The CI error: 

* running contrank.jl ...

ERROR: LoadError: LoadError: MethodError: ArrayViews.contrank(::Colon, ::Colon, ::Colon) is ambiguous. Candidates:

  contrank(i1::Colon, i2::Colon, i3::Colon, I::Union{Colon, Range, Real}...) in ArrayViews at /Users/travis/.julia/v0.6/ArrayViews/src/contrank.jl:54

  contrank(i1::Colon, i2::Colon, i3::Union{Colon, UnitRange}) in ArrayViews at /Users/travis/.julia/v0.6/ArrayViews/src/contrank.jl:46

Possible fix, define

  contrank(::Colon, ::Colon, ::Colon)

Stacktrace:

 [1] crank(::Colon, ::Colon, ::Vararg{Colon,N} where N) at /Users/travis/.julia/v0.6/ArrayViews/test/contrank.jl:15

 [2] test_crank(::Colon, ::Vararg{Colon,N} where N) at /Users/travis/.julia/v0.6/ArrayViews/test/contrank.jl:33

 [3] macro expansion at /Users/travis/.julia/v0.6/ArrayViews/test/contrank.jl:55 [inlined]

 [4] anonymous at ./<missing>:?

 [5] include_from_node1(::String) at ./loading.jl:576

 [6] include(::String) at ./sysimg.jl:14

 [7] macro expansion at /Users/travis/.julia/v0.6/ArrayViews/test/runtests.jl:10 [inlined]

 [8] anonymous at ./<missing>:?

 [9] include_from_node1(::String) at ./loading.jl:576

 [10] include(::String) at ./sysimg.jl:14

 [11] process_options(::Base.JLOptions) at ./client.jl:305

 [12] _start() at ./client.jl:371

while loading /Users/travis/.julia/v0.6/ArrayViews/test/contrank.jl, in expression starting on line 54

while loading /Users/travis/.julia/v0.6/ArrayViews/test/runtests.jl, in expression starting on line 7

On Julia 0.5.3 and ArrayViews 0.6.4 @which ArrayViews.contrank(:,:,:) points to https://github.com/JuliaArrays/ArrayViews.jl/blob/715d637fbdd0f6dca6a03d1f2d7c8d248b4abde8/src/contrank.jl#L54

I can't see what's changed that would cause the method ambiguity: https://github.com/goretkin/ArrayViews.jl/compare/goretkin:715d637...goretkin:8cd2ba9

goretkin commented 6 years ago

(method ambiguities fixed in #56)

goretkin commented 6 years ago

Closed in favor of https://github.com/JuliaArrays/ArrayViews.jl/pull/59