Closed theogf closed 2 years ago
Thanks @theogf ! I'll merge it like this for now - looks like we may be able to remove the StatsBase-specific code in the not too far future, StatsBase support for vector-valued samples is currently being improved.
Could you look into those test failures before I merge, @theogf ?
Hopefully the issues should have been fixed. The docs for cov
are confusing and it does not take a mean
argument (no idea why btw) and there was a coma typo. Sorry that you have to run the workflow manually every time
Sorry that you have to run the workflow manually every time
No worries, thanks for contributing!
Merging #22 (bddf6d0) into master (393a25d) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 7 7
Lines 451 451
=======================================
Hits 432 432
Misses 19 19
Impacted Files | Coverage Δ | |
---|---|---|
src/array_of_similar_arrays.jl | 97.26% <100.00%> (ø) |
|
src/statsbase_support.jl | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 393a25d...bddf6d0. Read the comment docs.
Thanks!
JuliaRegistries/General/52234
This matches the functions signatures in
Base
where themean
can be passed as kwarg. This allows the generic fallback ofmean_and_std
to work for example.Should I add some tests as well?