JuliaArrays / ArraysOfArrays.jl

Efficient storage and handling of nested arrays in Julia
Other
43 stars 9 forks source link

Fix stats functions signatures by adding `mean` keyword #22

Closed theogf closed 2 years ago

theogf commented 2 years ago

This matches the functions signatures in Base where the mean can be passed as kwarg. This allows the generic fallback of mean_and_std to work for example.

Should I add some tests as well?

oschulz commented 2 years ago

Thanks @theogf ! I'll merge it like this for now - looks like we may be able to remove the StatsBase-specific code in the not too far future, StatsBase support for vector-valued samples is currently being improved.

oschulz commented 2 years ago

Could you look into those test failures before I merge, @theogf ?

theogf commented 2 years ago

Hopefully the issues should have been fixed. The docs for cov are confusing and it does not take a mean argument (no idea why btw) and there was a coma typo. Sorry that you have to run the workflow manually every time

oschulz commented 2 years ago

Sorry that you have to run the workflow manually every time

No worries, thanks for contributing!

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (bddf6d0) into master (393a25d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files           7        7           
  Lines         451      451           
=======================================
  Hits          432      432           
  Misses         19       19           
Impacted Files Coverage Δ
src/array_of_similar_arrays.jl 97.26% <100.00%> (ø)
src/statsbase_support.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 393a25d...bddf6d0. Read the comment docs.

oschulz commented 2 years ago

Thanks!

oschulz commented 2 years ago

JuliaRegistries/General/52234