JuliaArrays / ArraysOfArrays.jl

Efficient storage and handling of nested arrays in Julia
Other
43 stars 9 forks source link

Drop Requires, reduce load time #26

Closed oschulz closed 2 years ago

oschulz commented 2 years ago

CC @cscherrer

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (19c681b) into main (4e340ac) will decrease coverage by 1.06%. The diff coverage is 100.00%.

:exclamation: Current head 19c681b differs from pull request most recent head 17bc6d9. Consider uploading reports for the commit 17bc6d9 to get more accurate results

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.91%   93.84%   -1.07%     
==========================================
  Files           7        5       -2     
  Lines         452      439      -13     
==========================================
- Hits          429      412      -17     
- Misses         23       27       +4     
Impacted Files Coverage Δ
src/array_of_similar_arrays.jl 94.15% <ø> (-0.04%) :arrow_down:
src/vector_of_arrays.jl 92.34% <ø> (-1.97%) :arrow_down:
src/arrays_of_static_arrays.jl 100.00% <100.00%> (ø)
src/ArraysOfArrays.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e340ac...17bc6d9. Read the comment docs.

oschulz commented 2 years ago

Before:

julia> @time_imports import InverseFunctions, ChainRulesCore, StatsBase, ArraysOfArrays
      1.1 ms  InverseFunctions
     57.3 ms  ChainRulesCore
     99.1 ms  StatsBase
    467.1 ms  ArraysOfArrays

After

julia> @time_imports import InverseFunctions, ChainRulesCore, StatsBase, ArraysOfArrays
      1.0 ms  InverseFunctions
     56.2 ms  ChainRulesCore
    103.2 ms  StatsBase
     60.2 ms  ArraysOfArrays