JuliaArrays / ArraysOfArrays.jl

Efficient storage and handling of nested arrays in Julia
Other
43 stars 9 forks source link

Tests for vector_of_arrays.jl #4

Closed sthayashi closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #4 into master will increase coverage by 5.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   71.84%   77.21%   +5.36%     
==========================================
  Files           7        7              
  Lines         373      373              
==========================================
+ Hits          268      288      +20     
+ Misses        105       85      -20
Impacted Files Coverage Δ
src/array_of_similar_arrays.jl 71.18% <0%> (ø) :arrow_up:
src/functions.jl 87.75% <0%> (+2.04%) :arrow_up:
src/vector_of_arrays.jl 78.77% <0%> (+10.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27a9008...99c3796. Read the comment docs.

oschulz commented 4 years ago

Is this still WIP?

sthayashi commented 4 years ago

Feel free to merge if it's acceptable. I'm not sure how many more tests you want written for this, because maybe other tests would be written differently with those two missing functions added in? I'll just push the little block of code I still have in a commit.

I've just been looking at array_of_similar_arrays.jl and getting a feel for how nested arrays are constructed and organized. I will have a PR started for that tonight/tomorrow.

sthayashi commented 4 years ago

Ready to be merged.

oschulz commented 4 years ago

Thanks!