Closed sthayashi closed 4 years ago
Merging #8 into master will increase coverage by 9.72%. The diff coverage is 100%.
9.72%
100%
@@ Coverage Diff @@ ## master #8 +/- ## ========================================== + Coverage 76.13% 85.86% +9.72% ========================================== Files 7 7 Lines 373 375 +2 ========================================== + Hits 284 322 +38 + Misses 89 53 -36
100% <100%> (+100%)
95.76% <0%> (+26.27%)
Continue to review full report at Codecov.
Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05cf466...e5a1443. Read the comment docs.
Δ = absolute <relative> (impact)
ø = not affected
? = missing data
Is this ready to be merged?
Yes, ready for merging.
Could you please put these tests in a separate file, "test_statsbase_support.jl"?
Nice!
Codecov Report
100% <100%> (+100%)
95.76% <0%> (+26.27%)
Continue to review full report at Codecov.