search

JuliaArrays / ArraysOfArrays.jl

Efficient storage and handling of nested arrays in Julia
Other
43 stars 9 forks source link

Added tests for StatsBase.jl support #8

Closed sthayashi closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 9.72%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   76.13%   85.86%   +9.72%     
==========================================
  Files           7        7              
  Lines         373      375       +2     
==========================================
+ Hits          284      322      +38     
+ Misses         89       53      -36
Impacted Files Coverage Δ
src/statsbase_support.jl 100% <100%> (+100%) :arrow_up:
src/array_of_similar_arrays.jl 95.76% <0%> (+26.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05cf466...e5a1443. Read the comment docs.

oschulz commented 4 years ago

Is this ready to be merged?

sthayashi commented 4 years ago

Is this ready to be merged?

Yes, ready for merging.

oschulz commented 4 years ago

Could you please put these tests in a separate file, "test_statsbase_support.jl"?

oschulz commented 4 years ago

Nice!