search

JuliaArrays / AxisArrays.jl

Performant arrays where each dimension can have a named axis with values
http://JuliaArrays.github.io/AxisArrays.jl/latest/
Other
200 stars 42 forks source link

Use categorical indexing behaviour by default for unknown array eltypes #116

Closed iamed2 closed 7 years ago

iamed2 commented 7 years ago

Previously, every unknown eltype (not a subtype of Number, AbstractTime, etc.) would require a new axistrait definition, or wrapping in a SortedVector or CategoricalVector type. Now, the default behaviour for indexing using an AbstractArray axis is Categorical, which requires only equality and not isless.

I also made arrays of Value types have the axistrait of either Categorical or Dimensional depending on the type they wrap, which maintains existing tested behaviour.

iamed2 commented 7 years ago

@mbauman @ajkeller34 review/merge?

ajkeller34 commented 7 years ago

Good grief, how has the Mac Travis CI been queued for 6 hours? I tested your branch on my Mac and it passed, so I'll just merge this since it also passed on Linux.

iamed2 commented 7 years ago

Travis really dropped the ball on maintenance of their Mac infrastructure: https://www.traviscistatus.com/