Fix performance bug: ensure `to_index` is inlined

JuliaArrays / AxisArrays.jl

Performant arrays where each dimension can have a named axis with values

http://JuliaArrays.github.io/AxisArrays.jl/latest/

Other

200 stars 41 forks source link

Fix performance bug: ensure `to_index` is inlined #170

Closed c42f closed 5 years ago

c42f commented 5 years ago

I believe this fixes #169 - looks like I needed an extra an @inline in #163

timholy commented 5 years ago

Bummer it doesn't do that automatically. Clearly the automatic inliner still needs some work. Though currently something that works for 3d might not for 4d, so perhaps for array operations we'll always need manual annotation.

c42f commented 5 years ago

Thanks Tim.