search

JuliaArrays / AxisArrays.jl

Performant arrays where each dimension can have a named axis with values
http://JuliaArrays.github.io/AxisArrays.jl/latest/
Other
200 stars 41 forks source link

Add AxisMatrix alias #199

Closed JeffFessler closed 2 years ago

JeffFessler commented 3 years ago

for consistency with AbstractArray and AbstractMatrix and other such types

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9b91d54). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   89.31%           
=========================================
  Files             ?        7           
  Lines             ?      674           
  Branches          ?        0           
=========================================
  Hits              ?      602           
  Misses            ?       72           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b91d54...3a76035. Read the comment docs.

JeffFessler commented 3 years ago

Thanks @johnnychen94 for handling the important one. This one is not urgent at all...

cmichelenstrofer commented 1 year ago

Should AxisMatrix be exported?

JeffFessler commented 1 year ago

Yes, and AxisVector too I think. That was an oversight on my part when I made the original PR. Want to make a PR?

cmichelenstrofer commented 1 year ago

done #222 . Note that unlike Vector or Matrix, AxisMatrix and AxisVector don't work as constructors (a bunch of new constructors would have to be created mirroring those for AxisArray). They are still useful for limiting function argument types.