search

JuliaArrays / BlockDiagonals.jl

Functionality for working efficiently with block diagonal matrices.
MIT License
51 stars 11 forks source link

Disambiguate (::ProjectTo) #85

Closed platawiec closed 2 years ago

platawiec commented 2 years ago

This resolves #84 by slightly restricting the type signature of (::ProjectTo{BlockDiagonal})(dx) to (::ProjectTo{BlockDiagonal})(dx::AbstractArray). This follows the pattern established in ChainRulesCore's ProjectTo definitions for linear algebra.

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (15a145c) into master (e0ea72c) will decrease coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   96.09%   95.89%   -0.20%     
==========================================
  Files           5        5              
  Lines         333      317      -16     
==========================================
- Hits          320      304      -16     
  Misses         13       13
Impacted Files Coverage Δ
src/chainrules.jl 100.00% <100.00%> (ø)
src/blockdiagonal.jl 85.93% <0.00%> (-0.63%) :arrow_down:
src/linalg.jl 95.18% <0.00%> (-0.23%) :arrow_down:
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0ea72c...15a145c. Read the comment docs.

willtebbutt commented 2 years ago

@platawiec thanks for this. Could you please bump the patch version? I'm happy to approve + release once that's done.