search

JuliaArrays / BlockDiagonals.jl

Functionality for working efficiently with block diagonal matrices.
MIT License
49 stars 11 forks source link

`promote_type` when multiplying `BlockDiagonal` with vectors and matrices #93

Closed mzgubic closed 2 years ago

mzgubic commented 2 years ago

Closes #92, closes #90

Should remove the need for #89.

@fchorney does it work for your use case?

codecov[bot] commented 2 years ago

Codecov Report

Merging #93 (3b4e37b) into master (57e4ec7) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   95.91%   95.92%   +0.01%     
==========================================
  Files           5        5              
  Lines         318      319       +1     
==========================================
+ Hits          305      306       +1     
  Misses         13       13
Impacted Files Coverage Δ
src/base_maths.jl 100.00% <100.00%> (ø)
src/blockdiagonal.jl 85.71% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57e4ec7...3b4e37b. Read the comment docs.

mzgubic commented 2 years ago

@fchorney could you review this please?