Open matthias314 opened 3 weeks ago
FTR, it's usually better to move an existing issue to the proper repo, than to create a new one. That's what I was asking for. Someone who's a member of JuliaArrays should be able to do that. Not that it matters much now.
Sorry, didn't know that!
I think reshape
in Base
should handle all Integer
s, and not just Int
s. In that case, we won't need to define these specialized methods here at all.
I agree. While looking into fixing this, I stumbled upon many open tickets for reshape
on Julia's issue tracker, which seem like they should somewhat be considered together. E.g.:
https://github.com/JuliaLang/julia/issues/17372
https://github.com/JuliaLang/julia/issues/27474
https://github.com/JuliaLang/julia/issues/39123
https://github.com/JuliaLang/julia/issues/39951
https://github.com/JuliaLang/julia/issues/40076
https://github.com/JuliaLang/julia/issues/45589
It's a bit overwhelming TBH.
Is this bug also in Julia v1.11-rc?
I think it’s a mistake to try to support master as it’s always too much of a moving target
The bug is that FillArrays relies on internal Julia functionality, _reshape_uncolon
from Base
, specifically. This is independent of Julia version, clearly.
It only manifests on nightly, though.
I discovered the following issue with the OffsetArrays tests, see JuliaArrays/OffsetArrays.jl#353. @nsajko suggested that I report it here and mention JuliaLang/julia#54261. The error happens both with FillArrays v1.11.0 and master: