Closed jishnub closed 1 year ago
Merging #288 (3a9c563) into master (5eeae03) will decrease coverage by
0.34%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 95.53% 95.19% -0.35%
==========================================
Files 5 5
Lines 426 437 +11
==========================================
+ Hits 407 416 +9
- Misses 19 21 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/OffsetArrays.jl | 96.87% <80.00%> (-0.60%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5eeae03...3a9c563. Read the comment docs.
Not necessary anymore, as the change has been reverted
Fixes #273, but this will need to be tested extensively to avoid breakages. Better or more robust solutions are welcome!
This PR delegates the
promote_type
operation to the parent wherever possible, and wraps theOffsetArray
type around the result.After this: