search

JuliaArrays / PaddedViews.jl

Add virtual padding to the edges of an array
Other
49 stars 9 forks source link

PaddedViews v0.5.7 #41

Closed IanButterworth closed 3 years ago

IanButterworth commented 4 years ago

There's some nice stuff on master that'd be good to be released 🙏🏻

cc. @johnnychen94

johnnychen94 commented 4 years ago

According to the discussion in https://github.com/JuliaArrays/PaddedViews.jl/pull/40#issuecomment-708405516, the inbounds semantic was incorrectly used. I'll need to revert part of #37 and #39 before we tag a new release.

So if we want to achieve optimal performance by skipping inbounds check, it's recommended to operate on parent(A::PaddedArray) instead. It is a bit ugly but it is conceptually safe.