search

JuliaArrays / ShiftedArrays.jl

Lazy shifted arrays for data analysis in Julia
Other
50 stars 10 forks source link

dont pirate convert: fix https://github.com/mauro3/Parameters.jl/issues/73 #20

Closed piever closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          52     52           
=====================================
  Hits           52     52
Impacted Files Coverage Δ
src/shiftedarray.jl 100% <ø> (ø) :arrow_up:
src/reduce.jl 100% <100%> (ø) :arrow_up:
src/offset.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb5b8ad...11a911a. Read the comment docs.

cstjean commented 6 years ago

I've been using this branch, and it fixed my issues. Any reason not to merge?

piever commented 6 years ago

Somehow I'm not sure that ShiftedArrays.convert(Array, v) is the best interface to convert a vector of N dimensional ShiftedArray into a N+1 dimensional Array. Do you have any suggestions on the API?

cstjean commented 6 years ago

array_from(vec_of_shifted_arrays)? I agree that convert is not super appropriate.

piever commented 6 years ago

You're right that this is not quite a conversion. I'll add some dedicated helper functions name and merge.