Closed roflmaostc closed 3 years ago
Merging #45 (00c5e37) into master (4ec21e7) will increase coverage by
0.19%
. The diff coverage is100.00%
.:exclamation: Current head 00c5e37 differs from pull request most recent head e41376a. Consider uploading reports for the commit e41376a to get more accurate results
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 98.21% 98.41% +0.19%
==========================================
Files 4 6 +2
Lines 56 63 +7
==========================================
+ Hits 55 62 +7
Misses 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/ShiftedArrays.jl | 100.00% <ø> (ø) |
|
src/fft_shifts.jl | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4ec21e7...e41376a. Read the comment docs.
Thank you, it mostly looks good, I've added a few comments.
I added your suggestions and also added the docstrings to the docs
Thanks. I've fixed the formatting (it should be uniform with the rest of the package) and merged.
Hey,
as discussed, this would fix #43 . I also added tests, it seems to be fine.
Furthermore I switched to GitHub Actions, due to the changed pricing for Travis I believe that GitHub Actions is now more or less standard.
Would be happy about your feedback!
Thanks,
Felix