search

JuliaArrays / StaticArrays.jl

Statically sized arrays for Julia
Other
762 stars 148 forks source link

Test `arithmetic_closure` against concrete types #1237

Closed jishnub closed 8 months ago

jishnub commented 8 months ago

On Julia nightly,

julia> subtypes(AbstractFloat)
5-element Vector{Any}:
 BigFloat
 Core.BFloat16
 Float16
 Float32
 Float64

and Core.BFloat16 does not have one defined for itself, which was leading to test failures. It's better to be explicit in the types that we test against, which are known to work.

jishnub commented 8 months ago

I'm not sure, but given that it's in Core and isn't public, it's probably some internal type. Perhaps it's best to not rely on its properties.