search

JuliaArrays / UnsafeArrays.jl

Stack-allocated pointer-based array views
Other
42 stars 5 forks source link

Base.reinterpret() #13

Closed green-nsk closed 2 years ago

green-nsk commented 2 years ago

related to https://github.com/JuliaArrays/UnsafeArrays.jl/issues/12 Just some work I did before I noticed there was already an WIP branch on origin

codecov[bot] commented 2 years ago

Codecov Report

Merging #13 (53e8df5) into main (654d42a) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   99.16%   99.21%   +0.05%     
==========================================
  Files           3        3              
  Lines         120      128       +8     
==========================================
+ Hits          119      127       +8     
  Misses          1        1
Impacted Files Coverage Δ
src/unsafe_array.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 654d42a...53e8df5. Read the comment docs.

oschulz commented 2 years ago

Thanks for contributing, @green-nsk . Could you see if the Julia v1.0 test failures can be fixed easily? If not, we could consider requiring Julia v1.6.

green-nsk commented 2 years ago

ERROR: LoadError: LoadError: syntax: invalid assignment location "s..."

Looking at the error message, this might fix it. Though I'll have to rely on GH workflows to see if it does -- I don't have Julia 1.0 handy.

oschulz commented 2 years ago

Looking at the error message, this might fix it.

Looks like it did. .-)

oschulz commented 2 years ago

Thanks @green-nsk

oschulz commented 2 years ago

https://github.com/JuliaRegistries/General/pull/63542