JuliaAstro / AstroLib.jl

Bundle of small astronomical and astrophysical routines.
http://juliaastro.github.io/AstroLib.jl/stable/
Other
79 stars 23 forks source link

Confusing double-meaning of the word "altitude" #80

Closed yakir12 closed 2 years ago

yakir12 commented 2 years ago

The word "altitude" is used for denoting an elevation angle (e.g. here) AND height from sea-level (e.g. here). This is confusing. I'm not sure what the best way to solve this is. Are there any agreed upon conventions? If it's impossible to agree on some standard, maybe include a note about it in the doc-strings?

giordano commented 2 years ago

I mean, the convention is precisely to call both of them "altitude". And the docstrings you linked (mostly borrowed from the upstream AstroLib package) already elaborate on what "altitude" they refer to.

yakir12 commented 2 years ago

Thanks for the rapid response!

I mean, the convention is precisely to call both of them "altitude".

Frustrating..

And the docstrings you linked (mostly borrowed from the upstream AstroLib package) already elaborate on what "altitude" they refer to.

I agree. OK, closing this then.