JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
39 stars 10 forks source link

Ported UTC<->TAI is incorrect during leap second #17

Closed helgee closed 6 years ago

helgee commented 6 years ago

The ports of taiutc and utctai are too simplistic and give an incorrect result during a leap second, see https://github.com/liberfa/erfa/blob/master/src/utctai.c, https://github.com/liberfa/erfa/blob/master/src/taiutc.c.

I have rolled the changes back and added two broken tests that should pass once the issue is fixed: https://github.com/JuliaAstro/AstronomicalTime.jl/blob/master/test/runtests.jl#L181

helgee commented 6 years ago

CC: @ashishpriyadarshiCIC

ashishpriyadarshiCIC commented 6 years ago

Ok @helgee .I'll start working on it