JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
38 stars 10 forks source link

jd2cal #23

Closed prakharcode closed 6 years ago

prakharcode commented 6 years ago

@helgee the type conversion is proving to be a problem. I've tried with round still the date part gives an error. @giordano any solution to this?

codecov-io commented 6 years ago

Codecov Report

Merging #23 into master will decrease coverage by 11.17%. The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #23       +/-   ##
===========================================
- Coverage    97.6%   86.42%   -11.18%     
===========================================
  Files           6        7        +1     
  Lines         292      361       +69     
===========================================
+ Hits          285      312       +27     
- Misses          7       49       +42
Impacted Files Coverage Δ
src/AstroTime.jl 100% <ø> (ø) :arrow_up:
src/utils.jl 0% <0%> (ø)
src/conversions.jl 99.06% <97.05%> (-0.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27cbb88...319b03e. Read the comment docs.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 173


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/conversions.jl 66 68 97.06%
src/utils.jl 0 40 0.0%
<!-- Total: 66 108 61.11% -->
Totals Coverage Status
Change from base Build 159: -11.2%
Covered Lines: 312
Relevant Lines: 361

💛 - Coveralls