JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
39 stars 10 forks source link

Tdbtcb #24

Closed prakharcode closed 6 years ago

prakharcode commented 6 years ago

1

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 178


Totals Coverage Status
Change from base Build 177: 0.5%
Covered Lines: 326
Relevant Lines: 375

💛 - Coveralls
codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c3938b). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage          ?   86.49%           
=========================================
  Files             ?        7           
  Lines             ?      348           
  Branches          ?        0           
=========================================
  Hits              ?      301           
  Misses            ?       47           
  Partials          ?        0
Impacted Files Coverage Δ
src/conversions.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c3938b...d24d056. Read the comment docs.

helgee commented 6 years ago

I was able to reproduce the test failure on Win32 on my Windows machine but I actually think that this an ERFA problem. The results from @prakharcode's code are consistent in 32/64 bits whereas the ERFA results are not.

helgee commented 6 years ago

I will merge this when I have fixed the problem within ERFA.

helgee commented 6 years ago

@prakharcode Forget what I said before and see my comment in the code.