search

JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
38 stars 10 forks source link

Fast and low accuracy TDB-TT difference computation. See https://gith… #27

Closed bgodard closed 6 years ago

bgodard commented 6 years ago

…ub.com/JuliaAstro/AstroTime.jl/issues/26.

EDIT: x-ref #26

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 168

Totals Coverage Status
Change from base Build 166: 0.02%
Covered Lines: 289
Relevant Lines: 296
💛 - Coveralls
codecov-io commented 6 years ago

Codecov Report

Merging #27 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   97.61%   97.63%   +0.01%     
==========================================
  Files           6        6              
  Lines         294      296       +2     
==========================================
+ Hits          287      289       +2     
  Misses          7        7
Impacted Files Coverage Δ
src/conversions.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 968b1e7...ba3d977. Read the comment docs.

helgee commented 6 years ago

This needs a test and there are some minor stylistic things, i.e. docstrings should use Markdown syntax and the docstring misses the function signature, but I will fix those myself after merging. Thanks a lot 👍

bgodard commented 6 years ago

I tested it by checking that for a large grid of dates in year range 1900-2100, the differences between both dtdb functions is within 40 us. I have now added the test.