Dat

[prakharcode]

Ported dat into leapseconds

[giordano]

A couple of general comments: do not parenthesize conditions; also errors should be covered by the tests.

[helgee]

Sorry @prakharcode for not raising this issue beforehand but a straight port from C won't cut it here. Most of the things that ERFA.dat does are already avaiable in the leapseconds method, see here: https://github.com/JuliaAstro/AstroTime.jl/blob/master/src/LeapSeconds.jl#L38

The best approach would thus be to replace the call to ERFA.dat in the branch at line 42 with ported code.

[coveralls]

Pull Request Test Coverage Report for Build 188

• 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 87.532%

---

Totals
Change from base Build 181:	0.1%
Covered Lines:	344
Relevant Lines:	393

---

💛 - Coveralls

[codecov-io]

Codecov Report

Merging #31 into master will increase coverage by 0.12%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage    87.4%   87.53%   +0.12%     
==========================================
  Files           7        7              
  Lines         389      393       +4     
==========================================
+ Hits          340      344       +4     
  Misses         49       49

Impacted Files	Coverage Δ
src/Epochs.jl	97.14% <ø> (ø)	:arrow_up:
src/conversions.jl	99.17% <ø> (ø)	:arrow_up:
src/LeapSeconds.jl	100% <100%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3799fae...ac3bc8c. Read the comment docs.

[helgee]

I will merge this as it is and propose a few improvements in a new PR. Thanks @prakharcode 👍

[prakharcode]

Thank you :smile: