search

JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
38 stars 10 forks source link

Use a script to generate leap seconds constants from an LSK kernel #32

Closed helgee closed 6 years ago

helgee commented 6 years ago

We currently download an LSK kernel with leap seconds data once and the parse it on every import. This is not incredibly useful since the download URL will change everytime NAIF publishes a new kernel. In consequence we will need to publish a new release everytime a new leap second is introduced which means that we could also (semi-)hard code leap seconds instead.

I propose to use a Julia script to generate a file with the required constants from an LSK kernel similar to the approach taken by Chrono.jl. This has the added benefit that AstroTime then does not need to depend on RemoteFiles.jl and OptionalData.jl anymore.

omus commented 6 years ago

Would it make sense to make a leap seconds package which both Chrono.jl and AstroTime.jl could use? I'll note that the TimeZones.jl already downloads the tzdata which contains the latest leap second information.

prakharcode commented 6 years ago

@omus yes! That's right! A package would be quite useful. @helgee I will try to create a package which will do as you suggested.

omus commented 6 years ago

Sounds good to me. If you want to create under the JuliaTime organization I can add create a repo and add members.

helgee commented 6 years ago

@omus Please do so and add @prakharcode and me 👍

helgee commented 6 years ago

Implemented in https://github.com/JuliaTime/LeapSeconds.jl