search

JuliaAstro / AstroTime.jl

Astronomical time keeping in Julia
https://juliaastro.github.io/AstroTime.jl/stable/
Other
39 stars 10 forks source link

Ported eraTcgtt #9

Closed prakharcode closed 6 years ago

prakharcode commented 6 years ago

progress for #1

ported eraTcgtt to pure Julia with test cases!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 96.38% when pulling e12ffa75ae178a7ffb37721825eb3539486340d6 on prakharcode:tcgtt into c49a39d8803b03bac6e93cbc03555aed55a2e303 on JuliaAstro:master.

codecov-io commented 6 years ago

Codecov Report

Merging #9 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   96.26%   96.38%   +0.11%     
==========================================
  Files           6        6              
  Lines         214      221       +7     
==========================================
+ Hits          206      213       +7     
  Misses          8        8
Impacted Files Coverage Δ
src/conversions.jl 99.03% <100%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c49a39d...e12ffa7. Read the comment docs.

helgee commented 6 years ago

Numerical discrepancies are not the answer here, they generally occur when calls to libm are involved (e.g. sin, exp, etc.). When we are dealing with simple arithmetic the results should be identical to the C version.

I know what's wrong with your code 😉 but I think you should try to figure it out yourself.