search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Julia package fetcher installed wrong FITSIO version #105

Closed rfetick closed 5 years ago

rfetick commented 5 years ago

Hello,

I report here an issue I had with FITSIO installation and reported to Stackoverflow. My Julia version seems incompatible with FITSIO since it automatically installed the wrong FITSIO package. I had to manually force the URL to download the correct one. Maybe the problem comes from my Julia version, I just let you know the issue.

Kind regards

giordano commented 5 years ago

I don't understand, the UUID of the package that I can read at https://stackoverflow.com/q/52274370/2442087 is correct (525bcba6-941b-5504-bd06-fd0dc1a4d2eb). Can you reproduce the error if you remove the package and try installing again with

pkg> update
pkg> add FITSIO
kbarbary commented 5 years ago

I don't think there is a FITSIO release that supports Julia 1.0 yet, is there? If not, you need the development version, which you can get with

pkg> dev FITSIO

rfetick commented 5 years ago

I agree it is quite strange...

When looking into the FITSIO.jl files the major difference is following. Wrong file

|type ImageHDU <: HDU fitsfile::FITSFile ext::Int end|

and replaced by (correct file)

*mutable struct ImageHDU <: HDU     fitsfile::FITSFile     ext::Int***end

Moreover the path to the package is different

packages/FITSIO/WueGk/ (wrong one)

packages/FITSIO/owJoM/ (good one)

I just tried to remove the package and add it again with add FITSIO, same error. Again I solved the problem by setting your github URL. For information, I am working on windows...

Romain

Le 12/09/2018 à 21:29, Mosè Giordano a écrit :

I don't understand, the UUID of the package that I can read at https://stackoverflow.com/q/52274370/2442087 is correct (|525bcba6-941b-5504-bd06-fd0dc1a4d2eb|). Can you reproduce the error if you remove the package and try installing again with

pkg> add FITSIO

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaAstro/FITSIO.jl/issues/105#issuecomment-420769432, or mute the thread https://github.com/notifications/unsubscribe-auth/AfKVAVlegodF2V_IUs9Q95NZr67-s_OIks5uaWCwgaJpZM4WlC7a.

giordano commented 5 years ago

Kyle is correct: the latest stable version of this package isn't compatible with Julia 1.0. This has been already fixed in the development version, but we haven't tagged a new version since then. The fact that the paths are different is normal, there is nothing strange with it, the package manager allows different versions to coexist.

Please, remove FITSIO.JL with

pkg> rm FITSIO
pkg> update
pkg> add FITSIO
pkg> dev FITSIO

After the rm, make sure you don't have any FITSIO.jl leftover, then you can reinstall and switch to the development version within the package manager, without installing another package

rfetick commented 5 years ago

Thanks for your comments :)

Romain

Le 13/09/2018 à 10:05, Mosè Giordano a écrit :

Kyle is correct: the latest stable version of this package isn't compatible with Julia 1.0. This has been already fixed in the development version, but we haven't tagged a new version since then. The fact that the paths are different is normal, there is nothing strange with it, the package manager allows different versions to coexist.

Please, remove FITSIO.JL with

pkg> rm FITSIO pkg> update pkg> add FITSIO pkg> dev FITSIO

After the rm, make sure you don't have any FITSIO.jl leftover, then you can reinstall and switch to the development version within the package manager, without installing another package

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaAstro/FITSIO.jl/issues/105#issuecomment-420920162, or mute the thread https://github.com/notifications/unsubscribe-auth/AfKVAeRWIAFAJAxtA0lr-GzdPdSYckZDks5uahG1gaJpZM4WlC7a.

giordano commented 5 years ago

The problem for me to use the development version of the package is that I didn't realize that there wasn't a stable version supporting julia 1.0 :sweat_smile: thanks to Kyle for pointing this out.

I'm going to tag a new version later today.

giordano commented 5 years ago

This can be closed, v0.12.0 has been available for a while now