JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Switch to CFITSIO.jl #138

Closed mileslucas closed 3 years ago

mileslucas commented 3 years ago

drone errors are due to lack of Julia 1.4 image

giordano commented 3 years ago

Yeah, I know... :disappointed: Julia 1.3 might work for 32-bit arm though

mileslucas commented 3 years ago

What still needs to be done for this?

mileslucas commented 3 years ago

@giordano oops, I think I needed to remove the deps folder. build.jl is being executed on a fresh install and failing because BinaryProvider isn't in the Project.toml. We shouldn't need the build script at all right? Testing locally right now.

giordano commented 3 years ago

Uh, yeah, my bad that didn't notice, but weird that this wasn't caught by CI :confused:

mileslucas commented 3 years ago

it looks like it was "caught" by CI, it just didn't break any of the tests because we didn't need any of the products from the build script. As it stands, this is just an installation inconvenience- I can confirm that even with the error FITSIO loads and works fine.

giordano commented 3 years ago

I see.