search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

loosen restrictions on table writing types #178

Closed mileslucas closed 2 years ago

mileslucas commented 2 years ago

Fixes #177

@andrew-saydjari I've added a test with the OrderedCollections.OrderedDict, can you take a look and let me know if this works for you?

codecov[bot] commented 2 years ago

Codecov Report

Merging #178 (ae6addc) into master (55c67ab) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   91.43%   91.52%   +0.09%     
==========================================
  Files           5        5              
  Lines         619      661      +42     
==========================================
+ Hits          566      605      +39     
- Misses         53       56       +3
Impacted Files Coverage Δ
src/table.jl 90.90% <100.00%> (+0.49%) :arrow_up:
src/header.jl 85.31% <0.00%> (-0.58%) :arrow_down:
src/FITSIO.jl 100.00% <0.00%> (ø)
src/image.jl 95.71% <0.00%> (+0.15%) :arrow_up:
src/fits.jl 96.25% <0.00%> (+0.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55c67ab...ae6addc. Read the comment docs.

andrew-saydjari commented 2 years ago

@mileslucas works perfectly on my side. Thanks for the feature addition!