Closed sefffal closed 2 years ago
Merging #180 (3616797) into master (0c6e209) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 91.11% 91.16% +0.05%
==========================================
Files 5 5
Lines 675 679 +4
==========================================
+ Hits 615 619 +4
Misses 60 60
Impacted Files | Coverage Δ | |
---|---|---|
src/header.jl | 85.63% <100.00%> (+0.32%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0c6e209...3616797. Read the comment docs.
Looks like there is one more challenge with trialling white space in some files! I will make a new PR for that as well.
In working on https://github.com/JuliaAstro/AstroImages.jl/issues/29, I found that for some images WCSLib could parse the headers in some FITS files just fine, but loading the headers with FITSIO and then calling
string
created headers that WCSLib could not read.Doing a before and after diff, I found there were some minor differences in how string values are formatted.
This PR changes the formatting so that WCS.jl and WCSLib can read headers loaded by FITSIO from more images.
Before:
After:
Original (loaded in DS9):
As you can see, string values are now left aligned and padded to 8 characters.