Closed sefffal closed 2 months ago
Merging #181 (8f5972c) into master (4591dde) will increase coverage by
0.09%
. The diff coverage is100.00%
.:exclamation: Current head 8f5972c differs from pull request most recent head 8951df9. Consider uploading reports for the commit 8951df9 to get more accurate results
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 91.16% 91.25% +0.09%
==========================================
Files 5 5
Lines 679 686 +7
==========================================
+ Hits 619 626 +7
Misses 60 60
Impacted Files | Coverage Δ | |
---|---|---|
src/header.jl | 86.17% <100.00%> (+0.53%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4591dde...8951df9. Read the comment docs.
Sounds good, request a review when you are ready for comments 👍🏻
This PR address three other formatting differences between FITSIO and other software:
END
at the end of the headers, also padded out to 80 columnsThese changes allows me to parse the headers of one more file with WCS.jl that previously failed. I'm marking this PR as a draft since the format still does not perfectly match DS9 and additional tweaks may be necessary. In particular, I noticed that some COMMENT headers have two
/
instead of one.These differences are subtle, so a diff tool or editor that shows white-space may be necessary to spot the changes.
Before:
After:
DS9: