search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

FileIO Integation / AstroImages.jl #183

Closed sefffal closed 1 year ago

sefffal commented 2 years ago

Hi all, I've been working on a PR to AstroImages.jl which relates to a few issues here:

Once merged, I would like to register AstroImages with FileIO so that users can load("abc.fits") and get an AstroImage but I see that FITSIO is already registered : https://github.com/JuliaIO/FileIO.jl/blob/f0e5b9568d684bb4c6851e1b737b9a344d22504c/src/registry.jl#L467

Adding AstroImages as a second format would override load when the user has both packages installed (and maintain the status-quo if the user only has FITSIO installed). The FileIO integration with FITSIO does not appear to be documented so hopefully this wouldn't break anyone's workflow.

Basically I wanted to check with the FITSIO maintainers that registering a second package that can read/write FITS files won't break anyone's workflow.

Thanks!

Edit the WIP docs for the update to AstroImages are here for now: https://sefffal.github.io/AstroImages.jl/dev/

sefffal commented 1 year ago

Opened a PR with FileIO: https://github.com/JuliaIO/FileIO.jl/pull/363

This also adds support for load("fits.gz") which previously fell back on Libz.jl.