JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Deletefix #190

Closed jbrinchmann closed 1 year ago

jbrinchmann commented 1 year ago

There is a bug in header.jl in the delete! function where the map was not updated in the FITSHeader which could cause problems when multiple keys are deleted in a header. This fixes that and also adds a test in runtests.jl to verify that deletion of two keys in sequence works.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (1dc2c10) 91.29% compared to head (b2a6162) 91.30%.

:exclamation: Current head b2a6162 differs from pull request most recent head fa02957. Consider uploading reports for the commit fa02957 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #190 +/- ## ========================================== + Coverage 91.29% 91.30% +0.01% ========================================== Files 5 5 Lines 689 690 +1 ========================================== + Hits 629 630 +1 Misses 60 60 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaAstro/FITSIO.jl/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro) | Coverage Δ | | |---|---|---| | [src/header.jl](https://app.codecov.io/gh/JuliaAstro/FITSIO.jl/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro#diff-c3JjL2hlYWRlci5qbA==) | `86.38% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaAstro/FITSIO.jl/pull/190/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.