Draft: address unsafe pointer operations (segfaults on nightly)

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia

http://juliaastro.org/FITSIO.jl/

MIT License

55 stars 29 forks source link

Draft: address unsafe pointer operations (segfaults on nightly) #196

Open sefffal opened 2 months ago

sefffal commented 2 months ago

These changes begin to address the unsafe operations used in this package. Currently these just deal with the most obvious issues. Repeatedly running tests on nightly reveal that there are still segfaults. I believe we are leaking pointers to C somewhere. This will also have to be addressed.

Note that tests are failing due to an unrelated issue with complex arrays that also impacts nightly.

Edit: there are some unrelated changes in the first three commits I will excise from this PR.

jishnub commented 3 weeks ago

I think it's fine to remove the reinterpreted complex tests (I was the one who had added these). These aren't relevant for the package as such.