search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Pull request/1a150c30 #20

Closed emmt closed 9 years ago

emmt commented 9 years ago

Same changes as before plus fix of unitialized variable nelements in fits_read_col and fits_write_col.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-4.75%) to 56.89% when pulling 1a150c30fbb5a1148e327ecc61303d3d3cd639c9 on emmt:pull-request/1a150c30 into 3001911efef010c799eee125f484082ba8d3e5a2 on JuliaAstro:master.

kbarbary commented 9 years ago

Looks good. For future reference, you can add commits to an existing PR, rather than creating a new one. Just add the commits to the same branch and push them to your github account and they will automatically show up in the PR. This is easier if you start by creating a branch (using command-line git) that has a more memorable name, like fix-types in this case. That way you can be sure you're adding commits to the correct branch. The latest manual has fairly good tips, but personally I tend to just use command-line git directly for most operations rather than Pkg from within Julia.

For this case, I'll merge this PR and close #19 as "superceded."

kbarbary commented 9 years ago

Travis reports a test failure on Julia 0.4, but reports that #19 passed on Julia 0.4. I don't see how the additional (2-line) commit would have caused a test failure, so basically I'm going to ignore it.

emmt commented 9 years ago

OK thanks for these guidelines, I agree that it is better the way you suggest.

Le 17/03/2015 15:16, Kyle Barbary a écrit :

Looks good. For future reference, you can add commits to an existing PR, rather than creating a new one. Just add the commits to the same branch and push them to your github account and they will automatically show up in the PR. This is easier if you start by creating a branch (using command-line git) that has a more memorable name, like |fix-types| in this case. That way you can be sure you're adding commits to the correct branch. The latest manual http://julia.readthedocs.org/en/latest/manual/packages/#code-changes has fairly good tips, but personally I tend to just use command-line git directly for most operations rather than |Pkg| from within Julia.

For this case, I'll merge this PR and close #19 https://github.com/JuliaAstro/FITSIO.jl/pull/19 as "superceded."

— Reply to this email directly or view it on GitHub https://github.com/JuliaAstro/FITSIO.jl/pull/20#issuecomment-82375311.

emmt commented 9 years ago

What are these mails that I receive from 'coveralls' ?

I hope I didn't do a mistake, but in principle there are more capabilities in the last commit for FITSIO...

Le 17/03/2015 15:20, Kyle Barbary a écrit :

Merged #20 https://github.com/JuliaAstro/FITSIO.jl/pull/20.

— Reply to this email directly or view it on GitHub https://github.com/JuliaAstro/FITSIO.jl/pull/20#event-256924662.

kbarbary commented 9 years ago

Coveralls is a service that reports changes in the test coverage (% of code lines run in the test suite). The comments are a bit annoying though... I'll try to turn them off.