search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Base.Uint8 is deprecated, use UInt8 instead #44

Closed jeff-regier closed 8 years ago

jeff-regier commented 8 years ago

With Julia 0.4 (the release candidate) I'm getting a lot of warnings about Uint8/UInt8 from just a few lines of FITSIO.jl. For example,

WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in fits_hdr2str at /home/travis/.julia/v0.4/FITSIO/src/libcfitsio.jl:410
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in wcspih at /home/travis/.julia/v0.4/WCSLIB/src/libwcs_h.jl:518
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in wcspih at /home/travis/.julia/v0.4/WCSLIB/src/libwcs_h.jl:518
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
in wcspih at /home/travis/.julia/v0.4/WCSLIB/src/libwcs_h.jl:518
WARNING: Base.Uint8 is deprecated, use UInt8 instead.
kbarbary commented 8 years ago

We're already using Compat in both packages, so we should just be able to find and replace Uint8 -> UInt8.

kbarbary commented 8 years ago

This has been fixed.