search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Fixes Julia 0.4-rc2 warnings #45

Closed jeff-regier closed 9 years ago

jeff-regier commented 9 years ago

Hi Kyle, This PR fixes all the deprecated warnings from FITSIO.jl caused by the recent changes to Julia 0.4.

kbarbary commented 9 years ago

Nice! One question: are the @compat(UInt8) necessary, or can you just do UInt8 once Compat is used? The later seems to work for me in the REPL.

jeff-regier commented 9 years ago

Oh, I see...it works for me too on the command line. I guess I shouldn't have put compat everywhere.

On Mon, Sep 28, 2015 at 7:51 PM Kyle Barbary notifications@github.com wrote:

Nice! One question: are the @compat(UInt8) necessary, or can you just do UInt8 once Compat is used? The later seems to work for me in the REPL.

— Reply to this email directly or view it on GitHub https://github.com/JuliaAstro/FITSIO.jl/pull/45#issuecomment-143928703.

jeff-regier commented 9 years ago

I've now removed the unnecessary calls to @compat.

kbarbary commented 9 years ago

Thanks!