search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Updates for Julia 0.6 #57

Closed andreasnoack closed 7 years ago

andreasnoack commented 7 years ago

Mainly the deprecation of the old Array constructor. I'm also using Ref in ccalls whenever possible. Finally, I'm dropping Julia 0.3 support since some of these changes won't work there and I don't think it is relevant to support anymore.

kbarbary commented 7 years ago

Thanks for this PR! I definitely agree we can drop Julia 0.3 support.

Looks like String(take!(io)) in runtests.jl is problematic on Julia 0.4 since it means AbstractString(take!(io)) there. Maybe we need a custom Julia version check here?

Alternatively, we could also drop Julia 0.4 support.

andreasnoack commented 7 years ago

I had forgotten to import Compat.String. Should work on 0.4 now as well.

kbarbary commented 7 years ago

Great, thanks!

andreasnoack commented 7 years ago

Would you mind making a new release? If you don't already know attobot, you should take a look at https://github.com/attobot/attobot. It makes it much simpler.

kbarbary commented 7 years ago

JuliaLang/METADATA.jl#7653

Attobot is nice.