search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Support memory backed files #58

Closed Keno closed 7 years ago

Keno commented 7 years ago

Support read-only memory backed files via ffomem. Also clean up a couple of deprecations while I'm here.

kbarbary commented 7 years ago

Thanks! Need a new tagged release for Celeste? Otherwise, will probably wait until 0.6 is out and more deprecation cleanups are done here.

Keno commented 7 years ago

No, I think we're ok. This is an option only, so not required to run something.

giordano commented 7 years ago

@Keno Should hidden have a parameter type T and the type FITS be parametrized by T, rather than having a field with abstract type?

Keno commented 7 years ago

No, hidden is never read, so its type doesn't matter. It's just there to give the GC and edge to the underlying memory to prevent it from being freed.

giordano commented 7 years ago

I see, thanks for the explanation.