search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Drop support for Julia 0.4 #72

Closed giordano closed 6 years ago

giordano commented 6 years ago

Compat.jl dropped support for Julia 0.4, so it's probably time to do the same here.

Note that String type doesn't guarantee there are only ASCII character in the string. If necessary, that should be tested with isascii.

kbarbary commented 6 years ago

:+1: Let's open another issue about adding isascii checks to all the string-related functions so that we don't forget. This will be a better interface than before: we didn't really want to disallow all the old UTF8Strings as input: only ones that contained characters outside the ASCII subset.

Looks good to me; feel free to merge.