search

JuliaAstro / FITSIO.jl

Flexible Image Transport System (FITS) file support for Julia
http://juliaastro.org/FITSIO.jl/
MIT License
55 stars 29 forks source link

Switch binary dependency to use BinDeps2 #96

Closed Keno closed 6 years ago

Keno commented 6 years ago

The builder repository is at https://github.com/Keno/CFITSIOBuilder, but should probably be transferred to JuliaAstro. In the process I had to bump the cfitsio version to 3420 from 3370 since that included some build system fixes, though I could probably backport those to 3370 if required.

BinDeps2 is somewhat experimental still, but if CI goes through, this should be usable.

giordano commented 6 years ago

if CI goes through, this should be usable

Something went wrong everywhere. Apparently, Travis + GNU/Linux + Julia 0.6 was able to get the dependency, but then the first test fails with

  ccall: could not find function ffinit in library /home/travis/.julia/v0.6/FITSIO/deps/usr/lib/libcfitsio.so
Keno commented 6 years ago

Yeah, might either be a problem with the library itself or might have something to do with the version bump. I'll investigate.

giordano commented 6 years ago

@Keno see #97

mweastwood commented 6 years ago

Thanks for your help getting CFITSIOBuilder working, Keno.

This PR is redundant now that #97 has been merged.