Closed helgee closed 4 years ago
coveralls
commented
4 years ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/d.jl | 1 | 98.37% | ||
| src/g.jl | 2 | 96.41% | ||
| src/cells.jl | 6 | 83.93% | ||
| <!-- | Total: | 9 | --> |
| Totals | |
|---|---|
| Change from base Build 246: | -0.2% |
| Covered Lines: | 2545 |
| Relevant Lines: | 2573 |
giordano
commented
4 years ago Yes, I'm not afraid of removing support for old versions of Julia: they won't enjoy new releases of the package, but the old ones will of course work. I believe the much easier installation and lower maintenance are worth the breakage.
Note that cirrus CI is probably kind of broken. You can just drop it and add freebsd to the operating systems for Travis
codecov[bot]
commented
4 years ago Merging #14 into master will decrease coverage by
0.30%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 99.22% 98.91% -0.31%
==========================================
Files 27 27
Lines 2568 2573 +5
==========================================
- Hits 2548 2545 -3
- Misses 20 28 +8 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/SPICE.jl | 98.43% <ø> (ø) |
|
| src/cells.jl | 83.92% <0.00%> (-10.42%) |
:arrow_down: |
| src/g.jl | 96.41% <0.00%> (-0.88%) |
:arrow_down: |
| src/c.jl | 100.00% <0.00%> (ø) |
|
| src/d.jl | 98.36% <0.00%> (ø) |
|
| src/e.jl | 99.19% <0.00%> (ø) |
|
| src/f.jl | 100.00% <0.00%> (ø) |
|
| src/h.jl | 100.00% <0.00%> (ø) |
|
| src/i.jl | 100.00% <0.00%> (ø) |
|
| src/l.jl | 100.00% <0.00%> (ø) |
|
| ... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update e2529fa...2a332b5. Read the comment docs.
helgee
commented
4 years ago In principle it would suffice to test on 1.5 and nightly, right?
giordano
commented
4 years ago I usually test packages with the oldest supported version of Julia (1.3 here) and the latest one (1, which is an alias for the latest stable release in the v1 series)
giordano
commented
4 years ago ...in addition to nightly
@giordano Do you think it's fine to just drop pre-1.3 Julia versions here? There are no new features or bug fixes and the old versions will remain functional.