Bug in dsphdr - Githubissues

JuliaAstro / SPICE.jl

Julia wrapper for NASA NAIF's SPICE toolkit

MIT License

54 stars 14 forks source link

Bug in dsphdr #23

Open cekmsu opened 5 months ago

cekmsu commented 5 months ago

https://github.com/JuliaAstro/SPICE.jl/blob/62323bd2c6fd0514b9b8d9c51e8ba291a3d8e28b/src/d.jl#L2025 Must be:

    handleerror()
    permutedims(jacobi)

cekmsu commented 1 month ago

https://github.com/JuliaAstro/SPICE.jl/blob/9f6f1f93d3e536f9c012ec174481ac6d77a3f7a2/test/d.jl#L664-L670 It is a weak test. It does not catch this bug.

helgee commented 1 month ago

PRs are welcome 👍