Remove unneeded methods and update benchmark results

JuliaAstro / SkyCoords.jl

Astronomical coordinate systems in Julia

https://juliaastro.github.io/SkyCoords.jl/stable

Other

26 stars 13 forks source link

Remove unneeded methods and update benchmark results #14

Closed kbarbary closed 7 years ago

kbarbary commented 7 years ago

re-ran Julia benchmark and re-ran Python benchmark with latest astropy v2.0.1.
deleted _eltype() (no longer used)
deleted array-oriented convert (not needed due to generic fallback in Base)

cc: @giordano

giordano commented 7 years ago

Looks good to me! Which version of Julia have you used? If it's Julia <= 0.6, I expect further speed-up in Julia 0.7, sincos there (entirely implemented in Julia) is way faster than sin and cos separately in previous versions (based on an external C library).

While you're at it, why not precompiling the package (maybe in another PR)? :-)

kbarbary commented 7 years ago

I'm running Julia 0.6. Precompilation added!