JuliaAstro / SkyCoords.jl

Astronomical coordinate systems in Julia
https://juliaastro.github.io/SkyCoords.jl/stable
Other
26 stars 13 forks source link

Support Accessors.jl #50

Closed aplavin closed 1 year ago

aplavin commented 1 year ago

Useful for code that works with coordinates generically and needs to modify them.

Also: fix unnoticed bug in EclipticCoords, add them to all tests.

Accessors only for 1.9, nothing is changed on older julia versions. Accessors.jl contains integrations with stable widely-used packages itself (eg https://github.com/JuliaObjects/Accessors.jl/pull/87), but it makes more sense to keep SkyCoords intergration here.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.20 :tada:

Comparison is base (f69923e) 90.47% compared to head (eab4df5) 95.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #50 +/- ## ========================================== + Coverage 90.47% 95.68% +5.20% ========================================== Files 3 4 +1 Lines 126 139 +13 ========================================== + Hits 114 133 +19 + Misses 12 6 -6 ``` | [Impacted Files](https://codecov.io/gh/JuliaAstro/SkyCoords.jl/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro) | Coverage Δ | | |---|---|---| | [ext/AccessorsExt.jl](https://codecov.io/gh/JuliaAstro/SkyCoords.jl/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro#diff-ZXh0L0FjY2Vzc29yc0V4dC5qbA==) | `100.00% <100.00%> (ø)` | | | [src/types.jl](https://codecov.io/gh/JuliaAstro/SkyCoords.jl/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro#diff-c3JjL3R5cGVzLmps) | `87.50% <100.00%> (+15.62%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/JuliaAstro/SkyCoords.jl/pull/50/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAstro)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aplavin commented 1 year ago

Bump...