search

JuliaAstro / Transits.jl

Flexible photometric transit curves with limb darkening
https://juliaastro.github.io/Transits.jl/dev/
MIT License
20 stars 6 forks source link

Simplify SimpleOrbit #19

Closed mileslucas closed 3 years ago

mileslucas commented 3 years ago

This PR removes r_star from the SimpleOrbit struct, and rewrites related methods to be nominally in units of the stellar radius. This corresponds with the new Keplerian implementation #6. In addition, a few random methods defined for SimpleOrbit were removed to clean up.

codecov[bot] commented 3 years ago

Codecov Report

Merging #19 (623ff98) into master (eef9e52) will decrease coverage by 2.98%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   83.65%   80.66%   -2.99%     
==========================================
  Files          10       10              
  Lines         618      569      -49     
==========================================
- Hits          517      459      -58     
- Misses        101      110       +9
Impacted Files Coverage Δ
src/orbits/Orbits.jl 100.00% <ø> (ø)
src/orbits/simple.jl 75.86% <90.90%> (+2.52%) :arrow_up:
src/Transits.jl 83.33% <100.00%> (-4.17%) :arrow_down:
src/secondary.jl 73.68% <100.00%> (-21.97%) :arrow_down:
src/integrated.jl 76.00% <0.00%> (-13.66%) :arrow_down:
src/quad.jl 88.23% <0.00%> (-6.14%) :arrow_down:
src/distributions.jl 86.36% <0.00%> (-5.64%) :arrow_down:
src/poly.jl 87.50% <0.00%> (-1.48%) :arrow_down:
src/elliptic.jl 88.52% <0.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eef9e52...623ff98. Read the comment docs.