JuliaAstro / WCS.jl

Astronomical World Coordinate Systems library for Julia
https://juliaastro.github.io/WCS.jl/latest/
MIT License
16 stars 12 forks source link

change naxis in wcs #43

Open guanyilun opened 2 years ago

guanyilun commented 2 years ago

Is there any reason why :naxis isn't included in setproperty!? For example I'm interested in a function like sub(n) in astropy.wcs that truncates the axes. It looks like the easiest way to implement this is to change naxis because everything else references that in getproperty, but I can't do that with setproperty! and had to call setfield!, so I wonder if there's some consideration behind the choice that I'm not aware of, or maybe that could be easily added? Thanks so much!

giordano commented 2 years ago

I'm taking the occasion to point out that we're going to have a JuliaAstro meeting next Friday at 19:00 UTC. You can read more on discourse: https://discourse.julialang.org/t/organising-juliaastro-meeting/72313/4

giordano commented 2 years ago

Regarding your question, I'm not an expert of WCS, but my guess is that naxis is supposed to be constant for each instance?